Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31603 )
Change subject: mainboard: Add ASRock H110M-DVS ......................................................................
Patch Set 10:
(5 comments)
Patch Set 8:
(5 comments)
Please reference the h110m-dvs.md from index.md, too.
Ok
https://review.coreboot.org/#/c/31603/8/Documentation/mainboard/asrock/h110m... File Documentation/mainboard/asrock/h110m-dvs.md:
https://review.coreboot.org/#/c/31603/8/Documentation/mainboard/asrock/h110m... PS8, Line 8: Intel company provides Firmware Support Package (2.0) ([intel FSP 2.0])
not a valid markdown link
Fixed
https://review.coreboot.org/#/c/31603/8/Documentation/mainboard/asrock/h110m... PS8, Line 13: :doc:`../../soc/intel/code_development_model/code_development_model.md`.
not a valid link. […]
Fixed
https://review.coreboot.org/#/c/31603/8/Documentation/mainboard/asrock/h110m... PS8, Line 32: parameters in FSP.fd to initialize the PEG x16 port:
it would be great if you could add support for setting these at runtime in a different commit
Yes, I would make this in one of the next patches.
https://review.coreboot.org/#/c/31603/8/Documentation/mainboard/asrock/h110m... PS8, Line 34: Peg0Enable = Enable
not a block in markdown
Fixed
https://review.coreboot.org/#/c/31603/8/Documentation/mainboard/asrock/h110m... PS8, Line 92: sudo flashrom -p internal --ifd -i bios --noverify-all -w coreboot.rom
that's already covered by the common flashing guide
Done