Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Paul Menzel, Reka Norman, Sumeet R Pawnikar, Peter Ou.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 )
Change subject: mb/google/nissa/var/craask: Modify DPTF settings
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71860/comment/1c770f95_58541584
PS5, Line 25: option THERMAL_SOLUTION_15W 1
Where is that field defined or used? I am not finding it in the current source code of origin/master […]
fw_config definition of crassk*:
https://docs.google.com/spreadsheets/d/1D4bBwJgoh8QTlkhb6shR2ncpCqhPxMDgMYEE...
settings is OS:
https://chrome-internal-review.googlesource.com/c/chromeos/project/nissa/cra...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd
Gerrit-Change-Number: 71860
Gerrit-PatchSet: 6
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 02 Feb 2023 00:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment
