Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32593
to look at the new patch set (#2).
Change subject: mb/google/cyan: Refactor to get rid of `pei_data` ......................................................................
mb/google/cyan: Refactor to get rid of `pei_data`
The SoC specific `struct pei_data` was filled with values that were later only consumed by the mainboard code again. Avoid jumping through this hoop and fill FSP UPDs directly.
The provided solution locates the SPD data in CBFS again to fill SMBIOS tables. This is not perfect. OTOH, this code isn't mainboard specific and doesn't belong here anyway.
Change-Id: Ib6103d5b9550846fe17c926631a013ff80b9598f Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/cyan/romstage.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/spd/spd_util.h 3 files changed, 44 insertions(+), 40 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/32593/2