Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46724 )
Change subject: libpayload/keyboard: Revise scancode set and translation config
......................................................................
Patch Set 2:
Hey folks, I hope I figured things out now. Would be nice to get
this tested as much as possible, especially on the Chromebooks
(Drallion?) that needed the PC_KEYBOARD_AT_TRANSLATED Kconfig.
So far I tested only QEMU. Will check on some laptops soon.
There is also a follow up that I don't deemed necessary. In
theory keyboards that don't allow switching the scancode set
might exist. But as long as we don't have any or can set the
correct translation mode in coreboot, I guess we can keep it
unmerged.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad85af516a7b9f9c0269ff9652ed15ee81700057
Gerrit-Change-Number: 46724
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 25 Oct 2020 00:28:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment