Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36483 )
Change subject: vendorcode/eltan/security: align mboot with coreboot tpm ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36483/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36483/4//COMMIT_MSG@13 PS4, Line 13: The pcr invalidation has been changed. To what?
https://review.coreboot.org/c/coreboot/+/36483/4//COMMIT_MSG@12 PS4, Line 12: only single a single digest : handled in a call. Do you mean?
only a single digest can be handled in a call
https://review.coreboot.org/c/coreboot/+/36483/4//COMMIT_MSG@9 PS4, Line 9: Align the eltan mboot support with coreboot tpm support to : limit the amount of custom code. : : We now only support SHA256 pcrs, only single a single digest : handled in a call. The pcr invalidation has been changed. Please use the fully allowed text width of 75 characters.