Attention is currently required from: Krishna P Bhat D, Rizwan Qureshi, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75514?usp=email )
Change subject: common/block/cse: Add config to split CSE firmware sync
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
overall we need to agree on a few things
1. traditionally, CSE sync is the way to perform two operations
a. switch from CSE RO to CSE RW
b. Allow CSE fw upgrade or downgrade if required
with the modified proposal, we are keeping the 1a. early in romstage (which we can't call it anymore CSE sync).
1b. is flexible either romstage or ramstage. maybe for PSR enabled platform, it will be in ramstage. the RPL-R or ADL devices, it still is performing the 1b. inside romstage.
hence, i would suggest to have three config to clarify the job description and call out the dependency in proper.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75514?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb984dedf44c25dcd0760b618d6c1e5de13d75c3
Gerrit-Change-Number: 75514
Gerrit-PatchSet: 2
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 10:19:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment