build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42489 )
Change subject: ACPI: Drop typedef global_nvs_t ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42489/2/src/mainboard/packardbell/m... File src/mainboard/packardbell/ms2290/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/42489/2/src/mainboard/packardbell/m... PS2, Line 5: void acpi_create_gnvs(struct global_nvs * gnvs) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/42489/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/nvs.h:
https://review.coreboot.org/c/coreboot/+/42489/2/src/soc/intel/common/block/... PS2, Line 34: } ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/42489/2/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/42489/2/src/southbridge/intel/bd82x... PS2, Line 653: struct global_nvs *gnvs = cbmem_add (CBMEM_ID_ACPI_GNVS, sizeof(*gnvs)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42489/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/lpc.c:
https://review.coreboot.org/c/coreboot/+/42489/2/src/southbridge/intel/i8280... PS2, Line 461: struct global_nvs *gnvs = cbmem_add (CBMEM_ID_ACPI_GNVS, sizeof(*gnvs)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42489/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801jx/lpc.c:
https://review.coreboot.org/c/coreboot/+/42489/2/src/southbridge/intel/i8280... PS2, Line 620: struct global_nvs *gnvs = cbmem_add (CBMEM_ID_ACPI_GNVS, sizeof(*gnvs)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42489/2/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/42489/2/src/southbridge/intel/ibexp... PS2, Line 558: struct global_nvs *gnvs = cbmem_add (CBMEM_ID_ACPI_GNVS, sizeof(*gnvs)); space prohibited between function name and open parenthesis '('