Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34145 )
Change subject: src/cpu/intel: Add sanity check for cpu turbo mode capability
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34145/5/src/cpu/intel/turbo/turbo.c
File src/cpu/intel/turbo/turbo.c:
https://review.coreboot.org/c/coreboot/+/34145/5/src/cpu/intel/turbo/turbo.c...
PS5, Line 107: cpuid_regs = cpuid(CPUID_LEAF_PM);
: turbo_cap = !!(cpuid_regs.eax & PM_CAP_TURBO_MODE);
It is intended if get_turbo_state() results in TURBO_DISABLED as "if (!turbo_cap && !turbo_en)" scen […]
Done
https://review.coreboot.org/c/coreboot/+/34145/5/src/cpu/intel/turbo/turbo.c...
PS5, Line 112: turbo_state = TURBO_UNAVAILABLE;
If get_turbo_state() in line 101 ensures that turbo_state is NOT TURBO_UNAVAILABLE, get_turbo_state […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34145
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1bc37fb339b4a0bb6a7cdc6cd4391575b22b55a
Gerrit-Change-Number: 34145
Gerrit-PatchSet: 10
Gerrit-Owner: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 21 Jul 2019 19:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment