Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssm-f board ......................................................................
Patch Set 42:
(9 comments)
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 7: *some*
Why only some? Why the stressing? Is there a programmer that does not work?
was copied from x11ssh, fixed
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 18: #
Does s3resume work?
no
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 25: detection
Only detection? What about the rest, like, ECC getting enabled? It either works, it doesn't, or your […]
needs testing
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 38: (acpi, src/mainboard/gigabyte/ga-h61m-s2pv/acpi/thermal.asl maybe?)
It's acpi, but don't do a copypasta from a copypasta please. […]
This comment does not say anything about copypasta^^ This is just an example how this was done there... of course this needs more checking
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 39: PCI function 4 swapped to 0 (huh?) : - PCI function 2 swapped to 0 (huh?)
Coalescing, very likely. […]
right, removed
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 41: - register differences to vendor firmare: : - BIOS_PCI_EXP_EN 1->0 : - PCI_EXP_EN 1->0 : - GPIO_TIER2_SCI_EN 1->0
And why is this an issue, exactly?
because I didn't check what these are until now
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 46: ## ToDo : : - Fix issues above : - Fix TODOs mentioned in code
That's rather obvious, I'd say.
Ack
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 50: - Validate slp registers : - Validate usb settings in devicetree
Validate how?
checking datasheets, testing....
https://review.coreboot.org/c/coreboot/+/35427/41/Documentation/mainboard/su... PS41, Line 78: : +------------------+--------------------------------------------------+ : | Other slots | 1x RS232 (ext) | : | | 1x RS232 header | : | | 1x TPM header | : | | 1x Power SMB header | : | | 5x PWM Fan connector | : | | 2x I-SGPIO | : | | 2x S-ATA DOM Power connector | : | | 1x XDP Port | : | | 1x External BMC I2C Header (for IPMI card) | : | | 1x Chassis Intrusion Header | : +------------------+--------------------------------------------------+
If you link the vendor's device page, I don't think you need to copypasta that information here.
This was merged for x11ssh, so this should be here, too. Paul Menzel requested to show the differences