Attention is currently required from: Andrey Pronin, Raul Rangel, Christian Walter, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59479 )
Change subject: drivers/tpm: Add always-shutdown-on-suspend DSD property
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/tpm/chip.c:
https://review.coreboot.org/c/coreboot/+/59479/comment/b218353a_5e22a6d9
PS2, Line 53: suspend
Should we name this s0ix so it's not confused with S3?
+1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia48ead856fc0c6e637a2e07a5ecc58423f599c5b
Gerrit-Change-Number: 59479
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Thu, 18 Nov 2021 22:31:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment