Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34427 )
Change subject: NOT_FOR_MERGE: Make FSP driver tolerate Picasso
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34427/5/src/drivers/intel/fsp2_0/no...
File src/drivers/intel/fsp2_0/notify.c:
https://review.coreboot.org/c/coreboot/+/34427/5/src/drivers/intel/fsp2_0/no...
PS5, Line 72: mignt
might
https://review.coreboot.org/c/coreboot/+/34427/5/src/drivers/intel/fsp2_0/no...
PS5, Line 75: */
Please use one of the suggested comment styles.
https://doc.coreboot.org/coding_style.html#commenting
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24a47a10482486e4755ba8ef18aebc767533905e
Gerrit-Change-Number: 34427
Gerrit-PatchSet: 5
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Apr 2020 06:08:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment