Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45914 )
Change subject: nb/intel/i945/memmap.c: Use `postcar_enable_tseg_cache` ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2: Code-Review+1
The `postcar_enable_tseg_cache` function is essentially equivalent to the removed code block.
It compiles on top of commit a5f4781d81 with `CONFIG_TSEG_STAGE_CACHE=y` and `CONFIG_SMM_TSEG=y`, runs on Lenovo ThinkPad X60s, and boots Linux 5.4.68 with SeaBIOS 1.14.0 and GRUB 2.0.4.
It looks good to me.
And suspend by both closing the lid and executing `sudo systemctl suspend` works and resumes successfully. Forgot to mention. Sorry.
Thanks for testing!