Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46399 )
Change subject: soc/mediatek/mt8192: fix impedance tracking channel number
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46399/4/src/soc/mediatek/mt8192/dra...
File src/soc/mediatek/mt8192/dramc_tracking.c:
https://review.coreboot.org/c/coreboot/+/46399/4/src/soc/mediatek/mt8192/dra...
PS4, Line 529: SET32_BITFIELDS(&ch[1].phy_ao.misc_impcal,
Can this be squashed into the commit under review?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46399
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafec2e14a4b0b318e30493ee49c07af5aad5f1e8
Gerrit-Change-Number: 46399
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 14:29:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment