Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31661 )
Change subject: soc/intel/braswell: Add SMBus support
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
I assume using SB common works for DIMM slot also?
It should. And if not, it should be fixed.
I don't know why Intel keeps re-inventing wheels, maybe
they are too bored. Usually, sb/common/ is the correct
choice.
https://review.coreboot.org/#/c/31661/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31661/3//COMMIT_MSG@10
PS3, Line 10: is available for this controller.
Generally no need to add a line break after every full stop.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3d4f657558a1aed21b083ef5cad08ea96e629c3
Gerrit-Change-Number: 31661
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Mar 2019 12:23:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment