Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tony Huang.
Subrata Banik has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/84139?usp=email )
Change subject: mb/google/ovis/var/deku: Remove DSP setting
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84139/comment/98dbb6f4_abcbeb04?usp... :
PS1, Line 14: TEST=emerge-ovis coreboot
: check dev beep works
did you check the device audio functionality still works ??
I assume after dropping the DSP setting the audio still works after booting to OS?
what about display audio ?
do you see any difference between `aplay -l` w/ and w/o this CL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84139?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia1102dd3dfaa8248b092317edc2a88466adc2bd8
Gerrit-Change-Number: 84139
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-CC: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Fri, 30 Aug 2024 06:29:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No