Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52704 )
Change subject: drivers/intel/gma/Kconfig: Simplify Skylake/Kaby Lake conditions
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52704/comment/739879d9_e3ae9a7d
PS1, Line 89: SOC_INTEL_COFFEELAKE \
: || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_COMETLAKE
How about these? SOC_INTEL_CANNONLAKE_BASE
CB:52715
https://review.coreboot.org/c/coreboot/+/52704/comment/c175f2ca_960bf63a
PS1, Line 117: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \
: SOC_INTEL_COMETLAKE
SOC_INTEL_CANNONLAKE_BASE
CB:52715
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52704
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie69bde31b58bbd973db00bd578a51477c5b21cab
Gerrit-Change-Number: 52704
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Timofey Komarov
happycorsair@yandex.ru
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 27 Apr 2021 20:31:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment