Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42062 )
Change subject: src/*: Update makefiles to exclude x86 code from non-x86 verstage ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42062/3/src/drivers/pc80/pc/Makefil... File src/drivers/pc80/pc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/drivers/pc80/pc/Makefil... PS3, Line 11: verstage-y += i8254.c Can we come up with a syntax something like:
verstage-x86_32-y += i8254.c
And at top-level:
verstage-y += verstage-$(ARCH-VERSTAGE-y)-y
That would achieve the same thing but with much less noise.
https://review.coreboot.org/c/coreboot/+/42062/3/src/lib/Makefile.inc File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/lib/Makefile.inc@50 PS3, Line 50: verstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c Anything in lib/ should be arch-agnostic. What was the build failure? I would rather just have stub get_timestamp() if there is no good timebase.
https://review.coreboot.org/c/coreboot/+/42062/3/src/soc/amd/common/block/pc... File src/soc/amd/common/block/pci/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/soc/amd/common/block/pc... PS3, Line 4: endif here should fix it
Maybe the placement of amd_pci_mmconf.c in this directory is a bit unfortunate.