Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34644 )
Change subject: util/cbfstool: Remove unused assignment ......................................................................
util/cbfstool: Remove unused assignment
This variable is overwritten on one branch of the next if statement, and the other branch returns, so this assignment does nothing.
Change-Id: I63737929d47c882bbcf637182bc8bf73c19daa9f Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: scan-build 8.0.0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34644 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/cbfstool/ifittool.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/util/cbfstool/ifittool.c b/util/cbfstool/ifittool.c index 3b16c3f..dce37c8 100644 --- a/util/cbfstool/ifittool.c +++ b/util/cbfstool/ifittool.c @@ -336,7 +336,6 @@ case ADD_REGI_OP: { struct buffer region; - addr = 0;
if (partitioned_file_read_region(®ion, image_file, name)) { addr = -convert_to_from_top_aligned(®ion, 0);