Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41760 )
Change subject: intel/fsp2_0: Add functions for adding Intel FSP version to coreboot table ......................................................................
Patch Set 15:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG@9 PS13, Line 9: would be added
is added
Done
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG@10 PS13, Line 10: is defined in [1].
The reference is not needed, as the commits are in the same branch and Gerrit (and once committed gi […]
Done
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG@12 PS13, Line 12: LinuxBoot payload cbmem utility
Do you mean u-root? Do they have there own cbmem utility, which has an option to print the coreboot […]
Yes, u-root has their own cbmem utility that by default can print them.
https://review.coreboot.org/c/coreboot/+/41760/13//COMMIT_MSG@15 PS13, Line 15: [1] https://review.coreboot.org/c/coreboot/+/41809
As written above, this could be removed. […]
Done