Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Initial setup for ramstage/early/romstage gpio config for screebo ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174275): https://review.coreboot.org/c/coreboot/+/74475/comment/cf538bce_670b1f7f PS1, Line 9: This adds the initial gpio configuration for the screebo initial variant. Possible unwrapped commit description (prefer a maximum 72 chars per line)
File src/mainboard/google/rex/variants/screebo/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174275): https://review.coreboot.org/c/coreboot/+/74475/comment/0601f156_cdbc1965 PS1, Line 39: PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174275): https://review.coreboot.org/c/coreboot/+/74475/comment/49e1b8af_2ac8bf7e PS1, Line 65: PAD_CFG_NF_LOCK(GPP_B11, NONE, NF1, LOCK_CONFIG), trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174275): https://review.coreboot.org/c/coreboot/+/74475/comment/d9d0c733_3253256a PS1, Line 89: PAD_NC(GPP_B23, NONE), please, no spaces at the start of a line