Attention is currently required from: Paul Menzel, Alexander Couzens.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63530 )
Change subject: [TESTME] mb/lenovo/t410: Complete and fix hybrid-graphics config
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/lenovo/t410/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/63530/comment/87771d9e_ce7f47e4
PS1, Line 143: register "ddc_mux_gpio" = "54"
Can’t `has_ddc_mux_gpio` be derived from having `ddc_mux_gpio` set?
We don't know if a value is set. If it's not initialized, it's 0. But that
doesn't tell us if it's an implicit 0 or if somebody actually set it to 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia42416b7d2aeebe193747f88bc168a9e0838e449
Gerrit-Change-Number: 63530
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sun, 10 Apr 2022 14:09:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment