Attention is currently required from: Paul Menzel, Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68754 )
Change subject: mb/google/glados/var/lars: Set SKU ID based on VPD
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/glados/variants/lars/variant.c:
https://review.coreboot.org/c/coreboot/+/68754/comment/b9133f25_58923fd3
PS1, Line 86: LILI
Is the spelling all upper case?
Chromebook hardware IDs are typically displayed as all uppercase
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148462b6f86b25fa8db26ea6e1537d1a5e47984b
Gerrit-Change-Number: 68754
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 17:23:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment