Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32256 )
Change subject: libpayload: keyboard: Add F11 and F12 support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/32256/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32256/1//COMMIT_MSG@10 PS1, Line 10: see seem
https://review.coreboot.org/#/c/32256/1//COMMIT_MSG@10 PS1, Line 10: This existing source file doesn't see to comply with the automatic formatter, : and it wants to make a lot of unrelated line changes so I've disabled : it. Please add a blank line above. Maybe even remove the paragraph.
https://review.coreboot.org/#/c/32256/1/payloads/libpayload/drivers/i8042/ke... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/#/c/32256/1/payloads/libpayload/drivers/i8042/ke... PS1, Line 61: KEY_F(11), : KEY_F(12) Why not add it directly behind `KEY_F(10)`.