Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43819 )
Change subject: mb/amd/mandolin: add default USB2 PHY tune parameters to devicetree
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43819/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43819/1//COMMIT_MSG@7
PS1, Line 7: default
Are they FSP defaults?
as far as I've seen those are both FSP and platform defaults
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43819
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ea2fb83522d8810fe84e0a3f42bf44f2f911461
Gerrit-Change-Number: 43819
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 21:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment