Attention is currently required from: Furquan Shaikh, Kangheui Won, Paul Menzel, Nikolai Vyssotski, EricR Lai.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48865 )
Change subject: mb/google/zork: adjust the eDP panel power sequence
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48865/comment/4747fcaa_7cda3714
PS13, Line 32: register "pwron_digon_to_de" = "0"
0 may not needed. due to soc register initial is 0. But up to you.
I would keep the value here, so when people check the panel sequence, they will know hows other sequence is.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8af35eee7777a8e71b42f0c128795290b8c2c93e
Gerrit-Change-Number: 48865
Gerrit-PatchSet: 14
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 25 Jan 2021 05:16:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment