Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43771 )
Change subject: mb/volteer: Disable TBT if platform is only USB3 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43771/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/43771/2/src/mainboard/google/voltee... PS2, Line 34: /* If the DB is USB3 disable TBT on the platform */ : if (fw_config_probe(FW_CONFIG(DB_USB, USB3_ACTIVE)) || : fw_config_probe(FW_CONFIG(DB_USB, USB3_PASSIVE))) { : mem_cfg->TcssItbtPcie0En = 0; : mem_cfg->TcssItbtPcie1En = 0; : mem_cfg->TcssDma0En = 0; : mem_cfg->TcssDma1En = 0; : } This whole thing can be replaced by probe statements in the baseboard devicetree:
``` device pci 07.0 on probe DB_USB USB4_GEN2 probe DB_USB USB4_GEN3 end device pci 07.1 on probe DB_USB USB4_GEN2 probe DB_USB USB4_GEN3 end ```
and the same with the DMA controllers