Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43005 )
Change subject: mb/ocp/deltalake: Send OEM IPMI command for CMOS clear when RTC failure is detected ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG@11 PS6, Line 11: This is to let the payload (LinuxBoot) do some handling. What kind of handling?
https://review.coreboot.org/c/coreboot/+/43005/6//COMMIT_MSG@13 PS6, Line 13: Tested on OCP Delta Lake How is this tested? How do you simulate RTC failure?
https://review.coreboot.org/c/coreboot/+/43005/6/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/43005/6/src/mainboard/ocp/deltalake... PS6, Line 42: uint8_t boot_dev4; Regarding boot order, how does the difference between systemboot and UEFI BDS affect it? What is boot_mode? How does user know which boot_dev (a uinit8_t) is for which boot device (a string)?