Attention is currently required from: Christian Walter, Angel Pons, Lean Sheng Tan.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68632 )
Change subject: mb/prodrive/atlas: add unique DIMM locators in smbios type17 ......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/prodrive/atlas/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68632/comment/e7f95f35_ace7d6ef PS1, Line 20: snprintf(dev_loc, sizeof(dev_loc), "DIMM-%d%d%d", mc, ch, mm);
As per the SMBIOS spec, this should be the name of the slot as printed on the mainboard. […]
Done
https://review.coreboot.org/c/coreboot/+/68632/comment/dfaf1e08_b60a44c2 PS1, Line 24: %d%d%d
nit: use `%u` because unsigned. […]
Done
https://review.coreboot.org/c/coreboot/+/68632/comment/36fbfe1a_823474c2 PS1, Line 35: MC-%d-CH-%d-DIMM-%d
nit: use `%u` because unsigned.
Done