[coreboot-gerrit] Change in coreboot[master]: device + util/sconfig: introduce new device `gpio`

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48582 )

Change subject: device + util/sconfig: introduce new device `gpio`
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/48582/4/src/device/device_const.c 
File src/device/device_const.c:

https://review.coreboot.org/c/coreboot/+/48582/4/src/device/device_const.c@1... 
PS4, Line 166: generic.id
> `gpio. […]

Done

https://review.coreboot.org/c/coreboot/+/48582/4/src/device/device_util.c 
File src/device/device_util.c:

https://review.coreboot.org/c/coreboot/+/48582/4/src/device/device_util.c@13... 
PS4, Line 134: generic.id
> `gpio. […]

Done

https://review.coreboot.org/c/coreboot/+/48582/4/src/device/device_util.c@23... 
PS4, Line 230: %d.%d", dev->path.generic.id
> I guess this should be just `%d", dev->path.gpio.id);`?

yup, indeed
> Also, do I miss something? is `-Wformat` not enabled?

Hmm, nope, doesn't loke like it ever was