V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31787 )
Change subject: soc/intel/cannonlake: Move power_state functions to pmutil.c
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c
File src/soc/intel/cannonlake/pmutil.c:
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@20...
PS1, Line 204: uint32_t deep_s3_pol;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/31787/1/src/soc/intel/cannonlake/pmutil.c@20...
PS1, Line 204: uint32_t deep_s3_pol;
please, no spaces at the start of a line
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If24c3feeb77f4fb692ef0bf38d537b2b54de3c36
Gerrit-Change-Number: 31787
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Mar 2019 17:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment