Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35321 )
Change subject: soc/fsp_broadwell_de: Add devhide functionality ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel... File src/soc/intel/fsp_broadwell_de/southcluster.c:
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel... PS10, Line 268: iio_hide(slot, func);
I there a reason you have not passed in the *dev-pointer to iio_hide and deal with device and functi […]
yeah, this way iio_hide() can be used in bootblock and ramstage. I wanted to use struct device* as well but then I realized what if we need to hide something before ramstage
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel... File src/soc/intel/fsp_broadwell_de/ubox.c:
https://review.coreboot.org/c/coreboot/+/35321/10/src/soc/intel/fsp_broadwel... PS10, Line 28:
Once you have ubox.c you can move get_busno1() from vtd. […]
sure will do it. But in interest of time lets land this as is.