Attention is currently required from: Stefan Reinauer.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54385 )
Change subject: Documentation: Add proposal to allow enabling serial console with a flag
......................................................................
Patch Set 2:
(1 comment)
File Documentation/technotes/2021-05-selectable-serial-console.md:
https://review.coreboot.org/c/coreboot/+/54385/comment/bf3e92cb_4898ab9f
PS1, Line 112: and change the default to whatever is found there.
The VPD driver is terribly inefficient in pre-RAM stages so I really wouldn't want it used for this. […]
I updated the proposal to use a cbfs file (created with cbfstool add-int).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1b0efc55880095f9d5d6d6e448f2c8677d57ff5
Gerrit-Change-Number: 54385
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 15:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment