Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58157 )
Change subject: soc/intel/common/cse: Reorganize firmware update checks for CSE Lite
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/58157/comment/a511bfd4_ab08595d
PS5, Line 651: (status == CSE_UPDATE_CORRUPTED
coreboot need not send DATA CLEAR command when there is an UPDATE CORRUPTED. […]
Why is that? How would we know if this is an upgrade or downgrade instance if the CSE partition is corrupted?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58157
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabecab8e373e65a11ba7fe1bfc125467571a0588
Gerrit-Change-Number: 58157
Gerrit-PatchSet: 5
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 08 Oct 2021 20:33:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment