[coreboot-gerrit] [XS] Change in libgfxinit[main]: gma: Do detection and connectors init after `All_Off'

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/83600?usp=email )

Change subject: gma: Do detection and connectors init after `All_Off'
......................................................................

gma: Do detection and connectors init after `All_Off'

The `Port_Detect.Init' and `Connectors.Init' steps have grown over time.
They used to do one-time initialization that could be done independently
from the current hardware state. However, with the introduction of Tiger
Lake, it becomes more reasonable to ensure a disabled state before those
init steps.

Actually, we already program DDI buffers in `Connectors.Init' that pro-
bably shouldn't change when the hardware is running. It only didn't mat-
ter because everybody is supposed to write the same static values.

Change-Id: Ia707470da385624dcbbe90c0c7f64fe71331b65e
Signed-off-by: Nico Huber 
---
M common/hw-gfx-gma.adb
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/00/83600/1

diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index 88a9760..46fb44b 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -599,8 +599,6 @@
       end if;

Panel.Setup_PP_Sequencer;
-      Port_Detect.Initialize;
-      Connectors.Initialize;

if Clean_State then
          Power_And_Clocks.Pre_All_Off;
@@ -619,6 +617,8 @@
       end if;

-------------------- Now restart from a clean state ---------------------
+      Port_Detect.Initialize;
+      Connectors.Initialize;
       Power_And_Clocks.Initialize;

if Config.Has_PCH then