Attention is currently required from: Angel Pons, Arthur Heymans, Maximilian Brune, Philipp Hug, ron minnich.
Hello Angel Pons, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83056?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Code-Review+1 by Angel Pons, Verified+1 by build bot (Jenkins)
Change subject: arch/riscv/pmp: Avoid race conditions in logging ......................................................................
arch/riscv/pmp: Avoid race conditions in logging
The problem is that currently all harts/cores are printing that information on the console. But we only need it to be printed by one of them, since all harts/cores are configured the same. So instead of synchronizing it and let it be printed by all of them I chose to only let it be printed by the working hart (aka BSP).
This adds a printk macro in the PMP code to avoid all harts writing onto the serial which causes crappy/broken output.
Signed-off-by: Maximilian Brune maximilian.brune@9elements.com Change-Id: Icaded168bd7302ad1ea29bebb7900810ebeff92d --- M src/arch/riscv/pmp.c 1 file changed, 17 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83056/3