Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34157 )
Change subject: soc/intel/cannonlake: Add device Ids for new CFL SKUs support ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34157/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34157/8//COMMIT_MSG@7 PS8, Line 7: soc/intel/cannonlake: Add device Ids for CFL Refresh support
The CNP-H IDs for instance. It doesn't matter much and […]
Done
https://review.coreboot.org/c/coreboot/+/34157/12/src/include/device/pci_ids... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/34157/12/src/include/device/pci_ids... PS12, Line 3095: #define PCI_DEVICE_ID_INTEL_SKL_ID_H_2 0x1900
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/34157/12/src/include/device/pci_ids... PS12, Line 3097: #define PCI_DEVICE_ID_INTEL_SKL_ID_S_2 0x190f
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/34157/12/src/include/device/pci_ids... PS12, Line 3098: #define PCI_DEVICE_ID_INTEL_SKL_ID_S_4 0x191f
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/34157/12/src/include/device/pci_ids... PS12, Line 3106: #define PCI_DEVICE_ID_INTEL_KBL_ID_DT_2 0x5918
please, no space before tabs
Done