Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37187 )
Change subject: soc/intel/{apl,cnl,dnv,skl}: Skip ucode loading by FSP-T ......................................................................
Patch Set 1:
(3 comments)
The FSP-T code is pretty bad/buggy especially in this regard. Did you test this?
https://review.coreboot.org/c/coreboot/+/37187/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37187/1//COMMIT_MSG@17 PS1, Line 17: Gen-6 Gen 4 actually.
https://review.coreboot.org/c/coreboot/+/37187/1/src/soc/intel/apollolake/fs... File src/soc/intel/apollolake/fspcar.c:
https://review.coreboot.org/c/coreboot/+/37187/1/src/soc/intel/apollolake/fs... PS1, Line 30: whioch which.
https://review.coreboot.org/c/coreboot/+/37187/1/src/soc/intel/denverton_ns/... File src/soc/intel/denverton_ns/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37187/1/src/soc/intel/denverton_ns/... PS1, Line 35: CONFIG_CPU_MICROCODE_CBFS_LOC Drop the Kconfig symbols, they are unused now?