13 Dec
2024
13 Dec
'24
5:47 a.m.
Attention is currently required from: Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85562?usp=email )
Change subject: soc/intel/xeon_sp/spr/acpi: Fix regression ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/xeon_sp/spr/acpi/uncore.asl:
https://review.coreboot.org/c/coreboot/+/85562/comment/70a9b57b_e258ecd1?usp... : PS3, Line 15: #define SOCKET_NAME 0 Maybe mention SOCKET_NAME = SOCKET << 1?
--
To view, visit https://review.coreboot.org/c/coreboot/+/85562?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice168bdebc46dc0cfb9c63c78c46a5d9ff2b7658
Gerrit-Change-Number: 85562
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Attention: Tim Chu Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 13 Dec 2024 04:47:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes