build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45408 )
Change subject: mb/ocp/deltalake: Override uart base address via VPD variable ......................................................................
Patch Set 1:
(18 comments)
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/uart.c:
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 10: int val = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 12: if (hexstr[0] == '0' && hexstr[1] == 'x') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 15: while (*hexstr) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 16: char c = *hexstr++; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 16: char c = *hexstr++; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 17: if (c >= '0' && c <= '9') code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 17: if (c >= '0' && c <= '9') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 19: else if (c >= 'a' && c <='f') code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 19: else if (c >= 'a' && c <='f') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 19: else if (c >= 'a' && c <='f') spaces required around that '<=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 21: else if (c >= 'A' && c <='F') code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 21: else if (c >= 'A' && c <='F') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 21: else if (c >= 'A' && c <='F') spaces required around that '<=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 23: val = (val << 4) | (c & 0xF); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 23: val = (val << 4) | (c & 0xF); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 24: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 26: return val; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45408/1/src/mainboard/ocp/deltalake... PS1, Line 42: #endif adding a line without newline at end of file