Attention is currently required from: Wonkyu Kim, Tim Wawrzynczak, John Zhao, Angel Pons, Nick Vaccaro, Eric Lai, Patrick Rudolph, Felix Held.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62778 )
Change subject: soc/intel/common/block/p2sb: Add helper function to enable BAR
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/p2sb/p2sblib.c:
https://review.coreboot.org/c/coreboot/+/62778/comment/b8959c09_8306c8a1
PS3, Line 13: uint32_t low_bar, uint32_t high_bar
In this topic, just wondering would pci support 64 bit read/write 😎
I thought Felix meant like this
void p2sb_dev_enable_bar(pci_devfn_t dev, uint64_t bar)
{
/* Enable PCR Base addresses */
pci_write_config32(dev, PCI_BASE_ADDRESS_0, (uint32_t)bar);
pci_write_config32(dev, PCI_BASE_ADDRESS_1, (uint32_t)(bar >> 32));
....
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica41e8e8bdfcfe855e730b3878b874070062ef93
Gerrit-Change-Number: 62778
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 17 Mar 2022 14:58:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment