Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31608 )
Change subject: prog_loader: Associate TS_END_ROMSTAGE timestamp with postcar if exist
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31608/1/src/arch/x86/postcar_loader.c
File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/#/c/31608/1/src/arch/x86/postcar_loader.c@164
PS1, Line 164: timestamp_add_now(TS_END_ROMSTAGE);
Well patchset #2 is removing load_postcar_cbfs() from
TS_END_ROMSTAGE.
[Subrata] I didn't get you. i don;t see any change in this file between patchset #1 and #2
https://review.coreboot.org/#/c/31608/1..2/src/arch/x86/postcar_loader.c
I'd rather keep it in, you can provide a followup
that adds individual stamps for postcar loader like the ones you
refer to used in run_ramstage().
[Subrata] We can do that as well, i will push separate CL for that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31608
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17fd89296354b66a5538f85737c79145232593d3
Gerrit-Change-Number: 31608
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ron Minnich
rminnich@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Mar 2019 04:38:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment