Attention is currently required from: Kevin Chiu, Nick Vaccaro, Shon Wang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59305 )
Change subject: mb/google/brya/var/vell: update gpio override ......................................................................
Patch Set 10:
(7 comments)
File src/mainboard/google/brya/variants/vell/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134424): https://review.coreboot.org/c/coreboot/+/59305/comment/d921c3d0_0d829a59 PS10, Line 173: /* B4 : PROC_GP3 ==> SSD_PERST_L */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134424): https://review.coreboot.org/c/coreboot/+/59305/comment/97c1f05e_9ae7e31c PS10, Line 174: PAD_CFG_GPO(GPP_B4, 1, DEEP), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134424): https://review.coreboot.org/c/coreboot/+/59305/comment/dfa2c516_eb7f5bee PS10, Line 174: PAD_CFG_GPO(GPP_B4, 1, DEEP), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134424): https://review.coreboot.org/c/coreboot/+/59305/comment/d3586edd_77e8ef2c PS10, Line 179: *num = ARRAY_SIZE(romstage_gpio_table); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134424): https://review.coreboot.org/c/coreboot/+/59305/comment/becc77ad_a6e83559 PS10, Line 179: *num = ARRAY_SIZE(romstage_gpio_table); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134424): https://review.coreboot.org/c/coreboot/+/59305/comment/e4e9f3a4_cae2c190 PS10, Line 180: return romstage_gpio_table; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134424): https://review.coreboot.org/c/coreboot/+/59305/comment/3a2b81b8_d7b41d6a PS10, Line 180: return romstage_gpio_table; please, no spaces at the start of a line