Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38342 )
Change subject: mb/pcengines/apu2/mainboard.c: Add SMBIOS type 16 and 17 entries ......................................................................
Patch Set 1:
Patch Set 1:
Shouldn’t this be chipset code?
There are reasons I did not do it chipset specific: 1. AGESA does not return ideal information about type 17. For apu2 platforms, it also returned information for DIMM 1 on Channel A, which is simply not present. Thus cannot implement a generic parser for DMI info from AGESA. 2. The maximum capacity in type 16 can't be determined so easily. For soldered down memory there are limits defined by board vendor. On the other hand, there are silicon vendor limitations for maximum supported memory capacity by the processor itself (which are unknown to me, AMD does not provide it in specifications for family 16h and family 14h processors which I searched). Defining a Kconfig for each board for max memory capacity would be too complex and I think it would not work out as it should.