[coreboot-gerrit] [XS] Change in coreboot[main]: mb/google/ovis/var/deku: Remove DSP setting

[Subrata Banik (Code Review)]

Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tony Huang.

Subrata Banik has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/84139?usp=email )

Change subject: mb/google/ovis/var/deku: Remove DSP setting
......................................................................

Patch Set 1:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84139/comment/0f9f6f9c_ca798e89?usp... :
PS1, Line 14: TEST=emerge-ovis coreboot
            :      check dev beep works
> Drop DSP UPD from ovis baseboard
> delete register "pch_hda_dsp_enable" = "1"
> delete register "pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
> delete register "pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
> delete register "pch_hda_idisp_codec_enable" = "1"
>
> Read from FSP debug output
> [SPEW ]  ------------------ HD Audio PreMem Config ------------------
> [SPEW ]   Enable                                         = 0
> [SPEW ]   DSP Enable                                     = 0 <---- changed
> [SPEW ]   DSP UAA Compliance                             = 0
> [SPEW ]   Audio Link: HDA Link                           = 0
> [SPEW ]   Hda Sdi0 Enable                              = 0
> [SPEW ]   Hda Sdi1 Enable                              = 0
> [SPEW ]   Audio Link: DMIC#0                            = 0
> [SPEW ]   DMIC#0 Clock Select                           = 0
> [SPEW ]   Audio Link: DMIC#1                            = 0
> [SPEW ]   DMIC#1 Clock Select                           = 0
> [SPEW ]   Audio Link: SSP#0                             = 0
> [SPEW ]   Audio Link: SSP#1                             = 0
> [SPEW ]   Audio Link: SSP#2                             = 0
> [SPEW ]   Audio Link: SoundWire#0                       = 0
> [SPEW ]   Audio Link: SoundWire#1                       = 0
> [SPEW ]   Audio Link: SoundWire#2                       = 0
> [SPEW ]   Audio Link: SoundWire#3                       = 0
> [SPEW ]   VC Type                                        = 0
> [SPEW ]   iDisp Codec Disconnect                         = 1 <----- changed
> [SPEW ]   iDisp Link Frequency                           = 0 <----- changed
> [SPEW ]   iDisp Link T-Mode                              = 0 <----- changed
> [SPEW ]   ResetWaitTimer                                 = 258
> [SPEW ]   SubSystemIds                                   = 0
> [SPEW ]   Sndw Multiline Enable                         = 0
>
> Any suggestion for deku?

this looks good. I assume if you are able to drop from Ovis baseboard then ideally you don't need to do anything special for Deku.

Can you please ensure there is no functional brokenness.