[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Update GPIOs for Tigerlake SOC

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36248 )

Change subject: soc/intel/tigerlake: Update GPIOs for Tigerlake SOC
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36248/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36248/3//COMMIT_MSG@30 
PS3, Line 30: BUG=None
> How can BUG be none when this commit fixes broken PMC?

its not broken rather delta over ICL for TGL.which is expected to be different . so good to mention the bug where we are capturing  entire TGL upstreaming work

https://review.coreboot.org/c/coreboot/+/36248/3/src/soc/intel/tigerlake/inc... 
File src/soc/intel/tigerlake/include/soc/pmc.h:

https://review.coreboot.org/c/coreboot/+/36248/3/src/soc/intel/tigerlake/inc... 
PS3, Line 21: #define  ABASE			0x40
> looks like this is important and PMC was broken before

with PMC revision change its expected that some reg offset moves around. so this is to capture that.