Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31491 )
Change subject: console: Refactor printk() varargs prototypes ......................................................................
Patch Set 3:
(1 comment)
If it's not inlined how is it linked then? a single implementation or one per calling compilation unit? Could we safe space by placing it into `printk.c`?
OHH! Yeah, that would explain why the binary blew up so much from such a small function. Good point, pulling it into .c was the right fix.
https://review.coreboot.org/#/c/31491/3/src/console/printk.c File src/console/printk.c:
https://review.coreboot.org/#/c/31491/3/src/console/printk.c@42 PS3, Line 42: static __inline
plain inline is preferred over __inline
Wait why are we inlining this now? Doesn't that duplicate all this code?