Attention is currently required from: Julius Werner, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81964?usp=email )
Change subject: util/cbfstool: Add --64 option for 64-bit payload stitching ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why not parse the ELF for architecture?
Also it's confusing/meaningless for !x86 payloads.
can you please elaborate a bit your review comments ?
for sure, I should have guarded those against x86 arch alone. But are you suggesting not to use any cmdline (like --64) and use ELF arch to know if the payload is 64-bit binary and then insert specific magic data into the header ?
I think you only need a cmdline if you cannot figure it out differently. OTOH the ELF does not conclusively say something about the entry point. For other type of payloads like flat binaries it's not possible to know this either I suppose.