[coreboot-gerrit] Change in coreboot[master]: soc/intel/elkhartlake/romstage: Do initial SoC commit till romstage

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44801 )

Change subject: soc/intel/elkhartlake/romstage: Do initial SoC commit till romstage
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44801/1/src/soc/intel/elkhartlake/r... 
File src/soc/intel/elkhartlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/44801/1/src/soc/intel/elkhartlake/r... 
PS1, Line 28: __weak
> Do you ever want a weak implementation of this function? A failure to build is better than a failure […]

Done

https://review.coreboot.org/c/coreboot/+/44801/1/src/soc/intel/elkhartlake/r... 
File src/soc/intel/elkhartlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/44801/1/src/soc/intel/elkhartlake/r... 
PS1, Line 24: __weak
> nit: the linker attributes are typically put in front of the function.

Done