Attention is currently required from: Ravi Kumar Bokka, mturney mturney, Arthur Heymans, Furquan Shaikh, Kyösti Mälkki, Yu-Ping Wu. Prasad Malisetty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57614 )
Change subject: libpayload: Export PCIe config info from coreboot to libpayload ......................................................................
Patch Set 42:
(4 comments)
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/57614/comment/d36c618f_fe99ee3c PS40, Line 148: uintptr_t pci_config_info;
Move this right below mem_chip_base?
Thanks for reviewing the changes and comments.
Sure, I will update in next patch version.
Thanks -Prasad
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/57614/comment/37fc3a42_4dbf61e0 PS40, Line 83: PCIE
PCI_INFO
Agree, I will modify in next patch version.
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/57614/comment/a71d05ef_875f8890 PS28, Line 505: |
use a logical or, not a bitwise one.
Hi Arthur,
Thanks for the review.
Missed to add logical OR. I will update it next patch version.
Thanks -Prasad
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/57614/comment/a3c83576_1f411aff PS40, Line 100: cbmem_add
This should be done somewhere else in the pcie code, as the cbmem entry itself is unrelated to the c […]
As of now we are not using common code. In coming release we are adding new changes to make use of common pcie code. I will try to accommodate this function in common pcie code. I will update in next patch version.
Thanks -Prasad