Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36844 )
Change subject: security/vboot: Remove buffer_size from struct vboot_working_data ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36844/1/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/36844/1/src/lib/coreboot_table.c@23... PS1, Line 235: vbwb->range_size = 0;
I think the problem is that we don't pass the whole range here, only the workbuffer part without the […]
Done
https://review.coreboot.org/c/coreboot/+/36844/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36844/1/src/security/vboot/common.c... PS1, Line 80: size
It's not too small for the firmware buffer? But I agree there's no need for the extra variable (and […]
Done